Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 --- Comment #2 from Michel Alexandre Salim <fedora@xxxxxxxxxxxxxxxxxx> 2010-11-07 12:52:06 EST --- Thanks for the review! EL-5 and EL-6 have reasonable Lua stacks, so (In reply to comment #1) > Just going over the old review tickets. This one builds fine and rpmlint is > silent. As expected for a ticket this old, there are some lines in the spec > which are unnecessary on modern Fedora (BuildRoot, first line of %install, the > entire %clean section) which I would recommend removing unless you plan to > target EPEL with the same spec. > EL-5 and -6 have decent Lua stacks (though -5 is a bit buggy right now), so it'd be nice to have this package there, yes. > I see a comment "# for checks" but I don't see any checks enabled and I don't > see anything that's obviously a test suite. Is there one? > Will investigate -- it's been a while! I suspect it comes from another Lua spec, for a package that does have a test suite. > Do you think that preloader.lua and precompiler.lua, which aren't in the > package-specific directory, are problematic? They don't conflict with anything > but the names do seem quite generic. I don't know much about Lua, however, so > I'll defer to you. I'll compare it with the packaging done for LuaRocks (Lua's equivalent of CPAN) and get back to you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review