Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526805 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2010-11-02 15:30:49 EDT --- Just going over the old review tickets. This one builds fine and rpmlint is silent. As expected for a ticket this old, there are some lines in the spec which are unnecessary on modern Fedora (BuildRoot, first line of %install, the entire %clean section) which I would recommend removing unless you plan to target EPEL with the same spec. I see a comment "# for checks" but I don't see any checks enabled and I don't see anything that's obviously a test suite. Is there one? Do you think that preloader.lua and precompiler.lua, which aren't in the package-specific directory, are problematic? They don't conflict with anything but the names do seem quite generic. I don't know much about Lua, however, so I'll defer to you. * source files match upstream. sha256sum: 2c9000f5744ca84b6c0d58bd8fb1d8d71c2841b01a75b3b201a486f88ffda864 loop-2.3-beta.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: lua-loop-2.3-0.1.beta.fc15.noarch.rpm lua-loop = 2.3-0.1.beta.fc15 = /usr/bin/env lua >= 5.1 lua-lpeg >= 0.8.1 lua-loop-doc-2.3-0.1.beta.fc15.noarch.rpm lua-loop-doc = 2.3-0.1.beta.fc15 = lua-loop = 2.3-0.1.beta.fc15 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. ? maybe generically named files * code, not content. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review