Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=649662 --- Comment #9 from Michel Alexandre Salim <fedora@xxxxxxxxxxxxxxxxxx> 2010-11-07 07:39:27 EST --- (In reply to comment #7) > Please check the updated spec and source file, waiting for your review > comments. > > Spec URL: http://viji.fedorapeople.org/SPECS/python-tilecache.spec > SRPM URL: > http://viji.fedorapeople.org/SRPMS/python-tilecache-2.11-3.fc13.src.rpm > > #002 Please find rpmlint output, resolved all errors. > > [mockbuild@dev06 SPECS]$ rpmlint python-tilecache.spec > > python-tilecache.spec:59: W: macro-in-%changelog %clean > python-tilecache.spec: W: no-cleaning-of-buildroot %clean > python-tilecache.spec: W: no-buildroot-tag > python-tilecache.spec: W: no-%clean-section > 0 packages and 1 specfiles checked; 0 errors, 4 warnings. > > > [mockbuild@dev06 SPECS]$ rpmlint > /home/mockbuild/rpmbuild/RPMS/noarch/python-tilecache-2.11-3.fc13.noarch.rpm > > python-tilecache.noarch: W: spelling-error %description -l en_US pluggable -> > plug gable, plug-gable, plugged This can be ignored, the spell checker is rather atrocious when it comes to technical terms > python-tilecache.noarch: W: spurious-executable-perm > /usr/share/doc/python-tilecache-2.11/Example.py.txt Need to be fixed. A user should not be able to accidentally execute a file that's supposed to be documentation! Looks like the file is already marked executable in the source tarball, so you can fix it in the %prep stage; just chmod -x it there > python-tilecache.noarch: W: no-manual-page-for-binary tilecache_seed.py > python-tilecache.noarch: W: no-manual-page-for-binary tilecache.fcgi > python-tilecache.noarch: W: no-manual-page-for-binary tilecache_http_server.py > python-tilecache.noarch: W: no-manual-page-for-binary > tilecache_install_config.py > python-tilecache.noarch: W: no-manual-page-for-binary tilecache_clean.py > python-tilecache.noarch: W: no-manual-page-for-binary tilecache.cgi Can be ignored (but if you want to borrow manpages from, say, Debian (where they normally add missing manpages) that's fine too. > 1 packages and 0 specfiles checked; 0 errors, 8 warnings. > > > [mockbuild@dev06 SPECS]$ rpmlint > /home/mockbuild/rpmbuild/SRPMS/python-tilecache-2.11-3.fc13.src.rpm > > python-tilecache.src: W: spelling-error %description -l en_US pluggable -> plug > gable, plug-gable, plugged Ignore > python-tilecache.src:59: W: macro-in-%changelog %clean A good practice is to double-comment the macros when you talk about them in %changelog -- replace %clean with %%clean > python-tilecache.src: W: no-cleaning-of-buildroot %clean > python-tilecache.src: W: no-buildroot-tag > python-tilecache.src: W: no-%clean-section Those are fine (on newer Fedora versions) > 1 packages and 0 specfiles checked; 0 errors, 5 warnings. > > #007 changelog and release details are updated properly. As Shakthi said, adding a newline between changelog entries would be greatly appreciated. Which editor do you use for editing your specfiles? I use Emacs, and there are several commands that are a lifesavers: 1. M-x rpm-add-change-log-entry Inserts a new %%changelog entry with the correct date stamp, author name and email, and version info (you might have to customize name & email using M-x customize-group, then entering group name 'rpm-spec' 2. M-x rpm-increase-release-tag increments the release tag 3. C-x h (select all) followd by M-x untabify converts all TABs in the specfile to spaces (so many specs suffer from a mix of tabs and spaces, making diff outputs hard to read) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review