Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609012 --- Comment #8 from Michal Ingeli <mi@xxxxx> 2010-11-05 06:20:39 EDT --- (In reply to comment #6) > (In reply to comment #5) > > - Project name and package name consistency GoodData-CL Vs. gooddata-cl > > - Build failed for f13 [1] > > F13 is too old. > > and also f14 [2]. > > Fixed. Ok. Builds fine. > > gooddata-cl.src: W: strange-permission gooddata-cli 0755L > > * file listed in %{_bindir}, rpmlint shouldn't be complaining > > Well this is about the Source file. Fixed. OK. > > - missing BuildDeps reported by koji: > > > > DEBUG util.py:260: No Package Found for axis >= 1.4 > > DEBUG util.py:260: No Package Found for javacc-maven-plugin > > DEBUG util.py:260: No Package Found for xpp3-minimal >= 1.1.3.8-3.4 > > DEBUG util.py:260: No Package Found for xstream >= 1.3.1 > > DEBUG util.py:260: No Package Found for json-lib > > DEBUG util.py:260: No Package Found for gdata-java > 1.39 > > This is on F13. That's too old. Ok. So this package is not stated for F13 and older, EL5 and older. - License OK. - Packager is not using and installing maven dependency maps, so [1] is not required. - Missing buildroot tag is OK, package is NOT for ancient releases. * few more rpmlint warnings: * E: explicit-lib-dependency json-lib Can rpm figure out the dependency by itself? * W: non-conffile-in-etc /etc/gooddata-cl/log4j.configuration Consider adding %config * W: class-path-in-manifest /usr/share/java/gooddata-cl/cli-1.1.4.jar [1] http://fedoraproject.org/wiki/Packaging/Java#maven -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review