Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnu-smalltalk - GNU Smalltalk https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174377 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-26 22:11 EST ------- Well, very quick look at this: * Why isn't %configure macro used in spec file? * Is exporting 'CCFLAGS' variable required? * make %{_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" The description CFLAGS="$RPM_OPT_FLAGS" is not needed when %configure macro is used. * -devel package should not require ldconfig call. * %{_bindir}/gst-config The content of this file is incorrect as this contains --------------------------------------------- gst_libs='@LDPATH@ -lnsl -lm ' ---------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review