[Bug 645801] Review Request: erlang-gettext - Erlang internationalization library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645801

Tim Niemueller <tim@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Tim Niemueller <tim@xxxxxxxxxxxxx> 2010-10-28 23:31:28 EDT ---
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is not silent, but messages are false positives/warnings:
  - Additionally I get: erlang-gettext.src: W: invalid-url Source0:
etnt-gettext-b55cb72.tar.gz
I suggest appending writing the URL given in the comment in the front,
github will still deliver the right package. This is not required though.
  - License file problem is reasonably explained. I suggest considering a iconv
run and/or reporting this issue upstream, maybe they are willing to include an
UTF-8 version in the next release.
  - only-non-binary-in-usr-lib: general Erlang packaging problem which cannot
be avoided in the package

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (MIT).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

downloaded# sha256sum ~/Downloads/etnt-gettext-b55cb72.tar.gz 
7fd314343d274b018d356d59664a4b343334c557f70368716bc7cf53fe60b9e5 
~/Downloads/etnt-gettext-b55cb72.tar.gz
package# sha256sum ~/rpmbuild/SOURCES/etnt-gettext-b55cb72.tar.gz 
7fd314343d274b018d356d59664a4b343334c557f70368716bc7cf53fe60b9e5 
/home/tim/rpmbuild/SOURCES/etnt-gettext-b55cb72.tar.gz

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
+ No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.

Looks all good to me. Nice job.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]