Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612581 --- Comment #15 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-10-27 06:11:09 EDT --- Ok, re-posting rpmlint output since a lot of changes happened. rpmlint output is now much shorted so I am posting it complete, with my comments at the end. spacewalk-backend.noarch: E: non-standard-dir-perm /var/log/rhn 0770L spacewalk-backend.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn.conf spacewalk-backend.noarch: W: log-files-without-logrotate /var/log/rhn spacewalk-backend-app.noarch: W: spelling-error %description -l en_US rhnpush -> Rhodanus, rhonchus, pushpin spacewalk-backend-app.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-app.conf spacewalk-backend-app.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_app.conf spacewalk-backend-applet.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-applet.conf spacewalk-backend-applet.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_applet.conf spacewalk-backend-config-files.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-config-management.conf spacewalk-backend-config-files.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_config-management.conf spacewalk-backend-config-files-tool.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-config-management-tool.conf spacewalk-backend-config-files-tool.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_config-management-tool.conf spacewalk-backend-iss.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-sat.conf spacewalk-backend-iss-export.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-sat-dump-internal.conf spacewalk-backend-libs.noarch: E: explicit-lib-dependency python-hashlib spacewalk-backend-package-push-server.noarch: W: spelling-error Summary(en_US) rhnpush -> Rhodanus, rhonchus, pushpin spacewalk-backend-package-push-server.noarch: W: spelling-error %description -l en_US rhnpush -> Rhodanus, rhonchus, pushpin spacewalk-backend-package-push-server.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-package-push.conf spacewalk-backend-package-push-server.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_upload_package-push.conf spacewalk-backend-package-push-server.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_upload.conf spacewalk-backend-server.noarch: W: conffile-without-noreplace-flag /etc/httpd/conf.d/zz-spacewalk-server-wsgi.conf spacewalk-backend-server.noarch: W: conffile-without-noreplace-flag /etc/httpd/conf.d/zz-spacewalk-server.conf spacewalk-backend-server.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server.conf spacewalk-backend-server.noarch: W: dangerous-command-in-%pre install spacewalk-backend-server.noarch: W: dangerous-command-in-%post rm spacewalk-backend-tools.noarch: E: explicit-lib-dependency python-hashlib spacewalk-backend-tools.noarch: E: explicit-lib-dependency spacewalk-backend-xml-export-libs spacewalk-backend-tools.noarch: W: conffile-without-noreplace-flag /etc/rhn/default/rhn_server_iss.conf spacewalk-backend-tools.noarch: W: manual-page-warning /usr/share/man/man8/spacewalk-debug.8.gz 1: warning: macro `\"' not defined spacewalk-backend-tools.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_satellite.conf spacewalk-backend-xmlrpc.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-xmlrpc.conf spacewalk-backend-xmlrpc.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_xmlrpc.conf spacewalk-backend-xp.noarch: W: conffile-without-noreplace-flag /etc/rhn/satellite-httpd/conf/rhn/spacewalk-backend-xp.conf spacewalk-backend-xp.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_server_xp.conf spacewalk-backend.src:308: W: deprecated-grep [u'egrep'] 19 packages and 0 specfiles checked; 4 errors, 31 warnings. non-standard-dir-perm for /var/log/rhn is OK since apache will have to have write permissions there. non-conffile-in-etc and conffile-without-noreplace-flag: for a lot of files. Please recheck every file in /etc if it's supposed to be a config file. If yes then they should have %config macro. I assume files under /etc/rhn/default are still used as base config file used by spacewalk. This should be addressed upstream but as such is not a packaging problem (and files can be kept non-config of course). I'd say special care for files in /etc/httpd/conf.d explicit-lib-dependency: false positives deprecated-grep: please use standard grep with proper switches log-files-without-logrotate: provided in sub-packages so no problem So two things: * just make sure you mark config files as config. Fix these things upstream. Only system config files are in /etc. Defaults can be in /usr/share * Use grep instead of egrep Other: Main package contains empty directory /usr/lib/python2.7/site-packages/spacewalk/wsgi and then populated /usr/share/rhn/wsgi/. I assume this is a mistake? sql subpackage has /usr/share/rhn/server/__init__.py file which is a copy of file in /usr/lib/. This file is needed for some sub-packages to work I guess since some are placing files under /usr/share/rhn/server. Otherwise the dir wouldn't be recognized as python module. Am I correct? In that case please instead of having copy of the file, create a symlink from one to the other. LICENSE files don't have to be included in every subpackage since they depend on each other. For example sql doesn't have to include LICENSE because main package includes it and this cascades down. Re. man pages and rpmlint warning: bug is elsewhere so no problem. All in all, package looks MUCH better now. It would be good if the sub-packages also placed files in python_sitelib but even now it's OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review