Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632970 --- Comment #5 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2010-10-24 08:11:36 EDT --- You can remove the following useless BuildRequires: - glib2-devel (already required by gtk2-devel) - gtk2-devel (already required by gnome-media-devel) - gstreamer-devel (already required by gstreamer-plugins-base-devel) But you must add the following Requires: - hicolor-icon-theme (to own %{_datadir}/icons/hicolor/48x48/apps/) - libbonobo (to own %{_libdir}/bonobo/servers/). Be careful by the way to unowned directories: neither %{_datadir}/%{name}/ nor %{_datadir}/pixmaps/%{name}/ are owned by your package. Please correct your %files section as following: %files -f %{name}.lang %defattr(-,root,root,-) %{_bindir}/%{name} %{_datadir}/%{name}/ %{_datadir}/pixmaps/%{name}/ %{_datadir}/icons/hicolor/48x48/apps/%{name}.png %{_libdir}/bonobo/servers/%{name}.server Please remove all the references to josm in the rec-applet-generate-tarball.sh script. Moreover, you should be able to choose the revision you want to download using the script (with a given parameter corresponding to revision), and mention it in the name of the generated source archive; otherwise the script is in fact useless and you'd better indicate in the comments how th grab the archive source: for example (here updated to the latest snapshot): %global bzr_revision 24 %global bzr_version 20101011 Name: rec-applet Version: 0 Release: 0.3.%{bzr_version}bzr%{?dist} [...] # The source for this package was pulled from upstream's vcs. Use the # following commands to generate the tarball: # bzr export -r %{bzr_revision} rec-applet-%{bzr_version}bzr.tar.bz2 lp:rec-applet Source0: %{name}-%{bzr_version}bzr.tar.bz2 Note that using the given bzr command in the comments, you'll get automatically a .tar.bz2 source archive, which should be better compressed than a .tar.gz one. You can take example on this comment to write a _real_ script to grab the sources. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review