Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641271 --- Comment #5 from Andrea V. <vezza@xxxxxxxxx> 2010-10-22 09:53:33 EDT --- (In reply to comment #3) > There is a problem that must be resolved with upstream before we can continue - > the files in bin/SpiffGtkWidgets are licensed as "GPLv2 only" making them > incompatible with the rest of the project that is GPLv3+ > (https://fedoraproject.org/wiki/Licensing#GPL_Compatibility_Matrix) This problem seems to be solved now because openerp is released under AGPLv3 > Other issues found during my review are > - the uploaded file has the first character in upper-case, but the content of > the srpm itself is fine, should be all lower-case > - cli_dir macro is defined but not used anywhere, please remove > - I'd personally use %{name} macro instead of the openerp-client string inside > the %build/%install/%files sections > - build in mock for rawhide and F-14 fails with > ... > + /usr/bin/python setup.py build > Error: Can not find dsextras or gtk.dsextras > > - the --vendor option shouldn't be used in new packages > (https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage) > - locales are not handled correctly, see > https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files that problems should be solved now in the last version that you can find here: Spec URL: http://vezza2.dyndns.org/openerp-client.spec SRPM URL: http://vezza2.dyndns.org/openerp-client-5.0.14-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review