Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #13 from Alex Lancaster <alexl@xxxxxxxxxxxxxxxxxxxxx> 2010-10-21 22:04:27 EDT --- (In reply to comment #10) > (In reply to comment #9) > I will rework this part to use the commit hash rather than the date. I'll also > fix the release tag to include the commit hash (at least the start of it), as > per the guideline on pre-releases. Got your updated spec, looks good. Thanks for fixing that. > > [ ? ] MUST: Static libraries must be in a -static package. > > Seems that generating a static package is optional, is this intentional? > > > Yes, this is intentional. Static libs are only needed to build some of the > small test programs that are included (but not built nor installed by default > Makefile). Check. > You can probably test with the BD iso from the link in comment #3. Actually, just after I submitted the review, I recompiled XBMC with libbluray support. It appears that xbmc dlopen()s libbluray.so.1 or otherwise doesn't link it into the binary, however it does correctly load. Unfortunately xbmc can't play an ISO directly, but I could loopback mount the ISO and then navigate to the folder and it did play the disc content (albeit with no Bluray menus, it just skipped to next playlist item), but seems to playback just fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review