Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637904 Michal Fojtik <mfojtik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-10-06 07:22:58 EDT --- REVIEW: [OK] Packages that contain Ruby Gems must be called rubygem-%{gemname} [OK] The Source of the package must be the full URL to the released Gem archive; [OK] The package must have a Requires and a BuildRequires on rubygems [OK] The Gem must be installed into %{gemdir} defined as [OK] Architecture-specific content must not be installed into %{gemdir} [OK] If the Gem contains binary content (e.g., for a database driver), it must be marked as architecture specific, and all architecture specific content must be moved from the %{gemdir} to the [#ruby_sitearch %{ruby_sitearch} directory] during %install [OK] First, %prep stage must contain %setup -q -c -T to create the directory where C libraries are compiled. [OK] Then at %build stage the Ruby Gem must be installed under the directory created at %prep stage to get C libraries compiled under there. [OK] Finally at %install stage the whole tree under the directory created at %prep stage should be copied (not moved) to under %{buildroot}%{gemdir}. All other review points are OK, macros are used consistently, GCC flags are set correctly. Koji build fails (http://koji.fedoraproject.org/koji/taskinfo?taskID=2517406), because there is no "rubygem-glib2-devel" package, but it should be here soon (https://bugzilla.redhat.com/show_bug.cgi?id=637448). Btw, just curious, but do you plan to package ruby-gtk bindings ? REVIEW+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review