Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639272 --- Comment #4 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-10-05 06:17:15 EDT --- (In reply to comment #2) > Some notes: > > * Unused macros > - It seems that %ruby_sitelib macro is used nowhere. Fixed. > > * Requires/BuildRequires > - rubygem(rake) is for $ rake test and s.add_development_dependency > in gemspec file, so this is not needed for "Requires" > (for BuildRequires this is needed). Fixed. > * Directory ownership issue > - The directory %geminstdir itself is not owned by any packages. Fixed. > > * %files > - Please check if %geminstdir/%gemname.gemspec is really needed > ( I guess not. Note that gemspec file is also installed under > %gemdir/specifications ) Well this file is needed in %check for executing 'rake'. I rather to preserve this file in -doc sub package with tests (if someone want to execute tests, he must be able to do that using 'rake') > * Document files > - I think for this package -doc file should be created and the following > entries should be moved to -doc: > ------------------------------------------------------------------ > %{geminstdir}/test > %{geminstdir}/Rakefile > %{geminstdir}/doc > %{gemdir}/doc/%{gemname}-%{version} > ------------------------------------------------------------------ Fixed. Spec URL: http://mifo.sk/RPMS/rubygem-rack-accept.spec SRPM URL: http://mifo.sk/RPMS/rubygem-rack-accept-0.4.3-3.fc13.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=251365 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review