Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638948 Nathaniel McCallum <nathaniel@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathaniel@xxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |nathaniel@xxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Nathaniel McCallum <nathaniel@xxxxxxxxxxxxxxxx> 2010-10-04 14:21:34 EDT --- [ OK ] specfiles match: 5d0348a502988cf7922a9a83a6d2f3cf [ OK ] source files match upstream: 1657e6c5d68889befcbae30cd8df805d [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ FAIL ] license field matches the actual license. Listed license is MIT, actual is 3-clause BSD. [ OK ] license is open source-compatible. [ OK ] license text included in package. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [ FAIL ] rpmlint is silent. Example scripts should be 644, they are a form of documentation. The should also be installed as %doc. Does chmod'ing the scripts 644 make the doc-file-dependency go away? [ OK ] final provides and requires are sane [ OK ] %check is present and all tests pass: [ OK ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ FAIL ] file permissions are appropriate. %doc scripts should be 644 [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers. [ OK ] no pkgconfig files. [ OK ] no libtool .la droppings. [ OK ] desktop files valid and installed properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review