Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624471 --- Comment #4 from Iain Arnell <iarnell@xxxxxxxxx> 2010-09-30 12:39:42 EDT --- (In reply to comment #3) > > FIX: Add perl(File::Spec) >= 0.84 (Build)Requires as the module can be > > dual-lived (http://search.cpan.org/search?query=File%3A%3ASpec&mode=all) in the > > future. > FIX: Version constrain misses in Requires. > > > FIX: (Build)Require perl(Momoize) >= 1.01 (used by Tagger.pm, version specified > > in META.yml) > FIX: Version constrain misses in Requires. > > > FIX: (Build)Require perl(Storable) >= 2.10 (used by Tagger.pm, version > > specified in META.yml) as the module can be dual-lived > > (http://search.cpan.org/search?query=Storable&mode=all) in the future. > FIX: Version constrain misses in Requires. > > Please fix all `FIX:' prefixed comments and publish new spec file. Do not > forget to filter unversioned dependencies having versioned siblings out. > Result: NOT APPROVED. Petr, please review https://fedoraproject.org/wiki/Packaging/Guidelines#Requires, specifically "if the lowest possible requirement is so old that nobody has a version older than that installed on any target distribution release, there's no need to include the version in the dependency at all". Since Memoize 1.01 is from 2002, File-Spec from 2003, and Storable 2.10 is from 2004, I think we're pretty safe in assuming that they've all been available for almost 10 Fedora releases now. Absolutely no need for explicit versioned requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review