[Bug 624471] Review Request: perl-Lingua-EN-Tagger - Part-of-speech tagger for English natural language processing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624471

--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-09-30 04:22:07 EDT ---
Changes:

--- perl-Lingua-EN-Tagger.spec 2010-08-16 16:53:02.000000000 +0200
+++ perl-Lingua-EN-Tagger.spec.1 2010-09-30 05:50:16.000000000 +0200
@@ -1,18 +1,21 @@
 Name:           perl-Lingua-EN-Tagger
 Version:        0.16
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Part-of-speech tagger for English natural language processing
-License:        GPL+ or Artistic
+License:        GPLv3
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Lingua-EN-Tagger/
 Source0:       
http://www.cpan.org/authors/id/A/AC/ACOBURN/Lingua-EN-Tagger-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
-BuildRequires:  perl(HTML::Parser) >= 3.45
+BuildRequires:  perl(File::Spec) >= 0.84
+BuildRequires:  perl(HTML::TokeParser) >= 3.45
 BuildRequires:  perl(Lingua::Stem) >= 0.81
+BuildRequires:  perl(Memoize) >= 1.01
 BuildRequires:  perl(Memoize::ExpireLRU) >= 0.55
+BuildRequires:  perl(Storable) >= 2.10
 BuildRequires:  perl(Test::More)
-Requires:       perl(HTML::Parser) >= 3.45
+Requires:       perl(HTML::TokeParser) >= 3.45
 Requires:       perl(Lingua::Stem) >= 0.81
 Requires:       perl(Memoize::ExpireLRU) >= 0.55
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
@@ -52,5 +55,9 @@
 %{_mandir}/man3/*

 %changelog
+* Thu Sep 30 2010 Iain Arnell <iarnell@xxxxxxxxx> 0.16-2
+- license is GPLv3
+- tweak buildrequires
+
 * Mon Aug 16 2010 Iain Arnell <iarnell@xxxxxxx> 0.16-1
 - Specfile autogenerated by cpanspec 1.78.


> FIX: License is GPLv3, not a perl-like (verified from Tagger.pm).
Ok.

> FIX: Add perl(File::Spec) >= 0.84 (Build)Requires as the module can be
> dual-lived (http://search.cpan.org/search?query=File%3A%3ASpec&mode=all) in the
> future.
FIX: Version constrain misses in Requires.

> FIX: Replace perl(HTML::Parser) Requires with versioned perl(HTML::TokeParser)
> as HTML::TokeParser is used in code. File a bug to upstream to replace
> perl(HTML::Parser) dependency with perl(HTML::TokeParser) in Makefile.PL.
Ok.

> FIX: (Build)Require perl(Momoize) >= 1.01 (used by Tagger.pm, version specified
> in META.yml)
FIX: Version constrain misses in Requires.

> FIX: (Build)Require perl(Storable) >= 2.10 (used by Tagger.pm, version
> specified in META.yml) as the module can be dual-lived
> (http://search.cpan.org/search?query=Storable&mode=all) in the future.
FIX: Version constrain misses in Requires.

Builds on F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2502971).

Please fix all `FIX:' prefixed comments and publish new spec file. Do not
forget to filter unversioned dependencies having versioned siblings out.
Result: NOT APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]