Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632808 --- Comment #4 from Robin Lee <robinlee.sysu@xxxxxxxxx> 2010-09-15 22:51:33 EDT --- I hope we can reach some kind of agreements on the above issues, and popularize the agreements over all Pyhton packages. * About python-setuptools requirement In the mechanism of Setuptools, there is no separation of BR and runtime requirement. Setuptools is actually a BR for this package, and not used at runtime. You may run 'grep -R -e '\(setuptools\|pkg_resources\|easy_install\)' src/zope/schema/' to see that. So I think it's no need to require python-setuptools. * About tests inclusion I now prefer including the tests. First, the tests may be run by users themself. Second, we should make as little change as possible to the upstream distribution, which is the very spirit of Fedora project. * About the text files in the module directory. I now don't prefer moving that files. First, if the tests are included, the text files are possibly needed in the module directory by the tests. Second, in those text files, expressions referring to the modules in the same directory may be employed, for example, 'Please refer to interface.py in this directory.' Third, in some bigger packages, the text files will spread over levels of directories, moving those files makes maintenance more difficult. I will update the package a moment later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review