Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632808 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |a.badger@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |a.badger@xxxxxxxxx --- Comment #3 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2010-09-15 17:54:17 EDT --- Good: * Package follows naming guidelines * spec file follows package name * License is ZPLv2.1 in spec and source which is an approved license. * LICENSE.txt file included in package * Spec file is readable * Source matches upstream * No shared libraries so no shared library handling needed * No bundled libraries found * Not a relocatable package * No locale files * All directories owned * Files not listed twice * Permissions are proper * Macros used consistently * Code, not content * No GUI applications * All filenames are utf-8 * Package builds in koji * rpmlint - okay. Notes on output below Needswork: * Why did you remove the Requires: python-setuptools? It seems to still be needed (check setup.py in the tarball or %{python_sitelib}/zope.schema-3.6.4-py2.6.egg-info/requires.txt * The python module directory contains three *.txt files that should go in the documentation instead and the tests subdirectory looks like it can be removed from the installed package. Notes: * Upstream has released 3.7.0 (as a zip file) * rpmlint: W: spelling-error Summary(en_US) schemas -> schema, sachems, schemes False positive python-zope-schema.src: W: no-cleaning-of-buildroot %install python-zope-schema.src: W: no-cleaning-of-buildroot %clean python-zope-schema.src: W: no-buildroot-tag python-zope-schema.src: W: no-%clean-section These are not needed on F13 and above. However, if you are planning on building for F12, you will need a %clean section. If this gets built in EPEL5 it will also need a buildroot tag and the code to clean that buildroot at the start of %install. ------- Once we resolve the two items in Needswork I'll approve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review