[Bug 634036] Review Request: python-zope-i18nmessageid - Message Identifiers for internationalization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634036

Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |a.badger@xxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |a.badger@xxxxxxxxx

--- Comment #1 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2010-09-15 20:55:58 EDT ---
Good:
* Package follows naming guidelines
* spec file matches package name
* License in spec and source is ZPLv2.1 which is approved
* License file included in package
* Spec file is readable
* Sources match upstream
* No locale files
* Not a shared library
* No bundled libraries
* Not relocatable
* Package owns all directories that it creates and nothing else but see below.
* Permissions are proper
* macros used consistently
* Package contains code, not content
* Not a GUI
* All filesnames are UTF8
* Builds in koji

Needswork:
* Why take out the setuptools and zope-filesystem deps?
* Owns %{python_sitearch}/zope which is owned by python-zope-filesystem.  Since
  python-zope-filesystem exists, why co-own %{python_sitearch}/zope instead of
  requiring zope-filesystem?


Output fronm rpmlint:
python-zope-i18nmessageid.src: W: no-cleaning-of-buildroot %clean
python-zope-i18nmessageid.src: W: no-buildroot-tag
python-zope-i18nmessageid.src: W: no-%clean-section

These are not needed if you only build for F13 or greater.  If you build for
EPEL5 or F12, you need to add them.  You pointed at the guidelines for this in
another review so I assume you know what to do if needed :-)

python-zope-i18nmessageid.x86_64: W: private-shared-object-provides
/usr/lib64/python2.6/site-packages/zope/i18nmessageid/_zope_i18nmessageid_message.so
_zope_i18nmessageid_message.so()(64bit)

It's not likely that a real shared library will have that name so it's unlikely
that that name will end up in an rpm requires.  However, we can filter it out
by setting this at the top of the spec::

  # Supplement rpm's internal dependency generator so that we don't get
erroneous
  # provides
  %global _use_internal_dependency_generator 0
  %global __find_provides /bin/sh -c "%{_rpmconfigdir}/find-provides | grep -v
'_zope_i18nmessageid_message.so' || /bin/true"
  %global __find_requires /bin/sh -c "%{_rpmconfigdir}/find-requires | grep -v
'_zope_i18nmessageid_message.so' || /bin/true"


Also note: I'm trying to get python-Chameleon into Fedora.  If you'd like to
submit your python-zope-i18n package for review, I'll review it since it's a
dep of python-Chameleon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]