Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629332 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-09-08 15:08:37 EDT --- Hi Marco, it seems your above linked SPEC file already contains the changes requested by David. However, you didn't upload a corresponding SRPM. Please always keep both files in sync, and bump the Release number every time you provide a modified package. Finally, post the URLs of the updated files so that the current reviewers get notified. Here are some further comments: - goaccess 0.3.1 has been released recently. Maybe you want to update the package to the new version. - According to the sources, the license seems to be GPLv2 only. - You can also remove BuildRequires: glibc-devel, pkgconfig, autoconf, automake, and libtool. - In %build, drop the definition of variable CPPFLAGS. It's not required. - Insert blank lines between the %changelog entries to increase legibility. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review