Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629332 David Nalley <david@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@xxxxxxx --- Comment #1 from David Nalley <david@xxxxxxx> 2010-09-05 01:11:28 EDT --- Marco: I can't sponsor you as a packager, however, I'll point out one or two things that jump out at me. First your source url doesn't conform to the package guidelines, see: https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net Second, your build requires are just a tad too explicit. You don't need to specify gcc or make. take a look here: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Your %files section has an empty %doc section and there are clearly docs that are appropriate to put in there. Your package has a license file, and it doesn't appear that's included either: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text You should use macros a bit more consistently - for instance in your files section it could be %{_mandir}/man1/* instead of /usr/share/man/man1/goaccess.1.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review