Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629145 --- Comment #8 from Peter Robinson <pbrobinson@xxxxxxxxx> 2010-09-06 18:15:02 EDT --- + rpmlint output $ rpmlint ghc-cmdargs* ghc-cmdargs.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum ghc-cmdargs.src: W: strange-permission cmdargs-0.4.tar.gz 0640L ghc-cmdargs.src: W: strange-permission ghc-cmdargs.spec 0640L ghc-cmdargs.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum ghc-cmdargs-prof.x86_64: E: devel-dependency ghc-cmdargs-devel ghc-cmdargs-prof.x86_64: W: no-documentation ghc-cmdargs-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/cmdargs-0.4/libHScmdargs-0.4_p.a 4 packages and 1 specfiles checked; 1 errors, 6 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 33c45101ddb9c5f1ab996633744bdc7d cmdargs-0.4.tar.gz + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install - Permissions on files must be set properly see rpmlint output ? %defattr line No way to tell as there is no %file manifest + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel - static libraries should be in -static There is a .a file contained but its not clear from the haskell package guidelines regarding this n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: + if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji + the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane + non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin n/1 Package should have man files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review