Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527402 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #7 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-08-30 02:36:19 EDT --- Here is the full review: * rpmlint says: gmock.src: W: spelling-error %description -l en_US jMock -> j Mock, jock, mock gmock.src: W: spelling-error %description -l en_US matchers -> marchers, matcher, matches gmock.src: W: spelling-error %description -l en_US minGW -> mingy, Mingus, mingle gmock.src: W: invalid-url Source0: http://googlemock.googlecode.com/files/gmock-1.4.0.tar.bz2 HTTP Error 404: Not Found gmock-devel.x86_64: W: no-manual-page-for-binary gmock-config gmock-devel.x86_64: W: no-manual-page-for-binary gmock_doctor.py gmock-devel.x86_64: W: no-documentation These can be ignored. You can ask upstream about manpages. gmock.src: W: no-version-in-last-changelog gmock.src:86: W: macro-in-comment %{_datadir} gmock.src:86: W: macro-in-comment %{name} gmock.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1) These need to be fixed. gmock.x86_64: W: shared-lib-calls-exit /usr/lib64/libgmock.so.0.0.0 _exit@xxxxxxxxxxx Any explanation for this one? ! It looks like the Group for the main packages should be "System Environment/Libraries" ! The lines %dir %{_includedir}/%{name} %{_includedir}/%{name}/*.h %{_includedir}/%{name}/internal could be shortened to %{_includedir}/%{name} ! In the specfile you use "gmock" and "%{name}" interchangably, which breaks marco consistency. ! The standard way of getting rid of rpath is via %configure sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool which will also save you a BR. The use of chrpath is left as a last resort. ? On the devel packages why do we have Requires: automake * The tests fail via g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o test/.libs/gmock-actions_test test/gmock-actions_test.o -L/usr/lib64 -lgtest lib/.libs/libgmock_main.so -Wl,--rpath -Wl,/usr/lib64 /usr/bin/ld: test/gmock-actions_test.o: undefined reference to symbol 'testing::internal::ExpectationBase::RetireAllPreRequisites()' /usr/bin/ld: note: 'testing::internal::ExpectationBase::RetireAllPreRequisites()' is defined in DSO /builddir/build/BUILD/gmock-1.4.0/lib/.libs/libgmock.so.0 so try adding it to the linker command line /builddir/build/BUILD/gmock-1.4.0/lib/.libs/libgmock.so.0: could not read symbols: Invalid operation collect2: ld returned 1 exit status The undefined reference error can be fixed by adding a lib/.libs/libgmock.so to the compilation line. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review