Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544451 --- Comment #8 from Conrad Meyer <konrad@xxxxxxxxxx> 2010-08-26 12:41:00 EDT --- (In reply to comment #6 and #7) > [-] MUST: rpmlint must be run on every package. The output should be posted in > the review. > > $ rpmlint *.rpm *.spec > rescene.i686: W: spelling-error Summary(en_US) metadata -> meta data, > meta-data, metatarsus > rescene.i686: W: spelling-error %description -l en_US metadata -> meta data, > meta-data, metatarsus > rescene.i686: E: no-binary > rescene.i686: W: only-non-binary-in-usr-lib > rescene.i686: W: no-manual-page-for-binary rescene > rescene.src: W: spelling-error Summary(en_US) metadata -> meta data, meta-data, > metatarsus > rescene.src: W: spelling-error %description -l en_US metadata -> meta data, > meta-data, metatarsus > rescene.src:52: W: macro-in-comment %{_libdir} > rescene.src:52: W: macro-in-comment %{name} > rescene.spec:52: W: macro-in-comment %{_libdir} > rescene.spec:52: W: macro-in-comment %{name} > 2 packages and 1 specfiles checked; 1 errors, 10 warnings. > > At least macro-in-comment errors must be fixed. > > ... > > Please fix macro in comments errors. Except this package is fine. > APPROVED. Fixed. > Ahh, forgot ask. > Why you make decision name binary as rescene? On start without flags it produce > help where name himself as ssr. I think it also should be fixed. Please rename > binary or substitute it name in srr.cs source file with comment in spec why you > do it. Fair enough, fixed. New URLs: http://konradm.fedorapeople.org/fedora/SPECS/rescene.spec http://konradm.fedorapeople.org/fedora/SRPMS/rescene-1.2-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review