[Bug 606205] Review Request: halberd - Tool to discover HTTP load balancers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606205

--- Comment #5 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2010-08-15 05:20:59 EDT ---
Thanks for the review.

(In reply to comment #4)
> i. There is another deprecation warning, when you shoot halberd against an
> https URL. Sorry for this late report... I've just noticed it today. Please,
> ask upstream for another patch to fix that also:
>    /usr/lib/python2.6/site-packages/Halberd/clientlib.py:330:
> DeprecationWarning: socket.ssl() is deprecated.  Use ssl.wrap_socket() instead.

Upstream applied my patch and released 0.2.4 some hours ago.  I think that it
would not be a problem to fix this issue upstream.

> ii. Consider include a comment to the patches in SPEC file, to inform the
> upstream's bugtracking number for them.

There is no upstream tracker.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]