Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606205 Rafael Aquini <aquini@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Rafael Aquini <aquini@xxxxxxxxx> 2010-08-14 18:29:20 EDT --- Fabian, Your work in halberd is pretty fine, and I'm approving this package. However, I'd like ask you to consider the following suggestions before you commit halberd in git: i. There is another deprecation warning, when you shoot halberd against an https URL. Sorry for this late report... I've just noticed it today. Please, ask upstream for another patch to fix that also: /usr/lib/python2.6/site-packages/Halberd/clientlib.py:330: DeprecationWarning: socket.ssl() is deprecated. Use ssl.wrap_socket() instead. ii. Consider include a comment to the patches in SPEC file, to inform the upstream's bugtracking number for them. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review