Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612581 --- Comment #7 from Miroslav Suchý <msuchy@xxxxxxxxxx> 2010-08-13 13:17:34 EDT --- In this comments I list issues which I addressed without any objections. Items which I would like to comment or discuss will be sent in separate comment so we can better back reference. >NEEDSWORK: All build dependencies must be listed in BuildRequires, except for >any that are listed in the exceptions section of the Packaging Guidelines ; >inclusion of those as BuildRequires is optional. Apply common sense. > >-libs sub-package has BR on python-devel. Better use python2-devel > Also use proper macros to define python_sitearch on F12/RHEL-5 addressed ad man pages. filled BZs: 623965, 623967, 623964, 623966 I will address them in near future. > * use %global instead of %define (see addressed > to call python use %{__python} macro addressed >I guess this was supposed to be replaced? "XXX To be determined if the... yes. removed this XXX > Requires(pre) is accompanied with Requires:. When you have addressed >instead of %{_prefix}/share/rhn use %{_datadir}/rhn not needed with new definition >most of sub-packages install python files into /usr/share. This >is not proper way to deal with python packaging. These files should be moved >into proper %{python_sitelib} sub-directory addressed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review