Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621015 --- Comment #2 from Mohammed Morsi <mmorsi@xxxxxxxxxx> 2010-08-10 17:04:09 EDT --- (In reply to comment #1) > Some notes: > > * Unused macro > - %ruby_sitelib seems to be used nowhere. Removed > > * Latest version > - Latest version seems 2.1.6. Updated > > * Requires > - ">= 0" part on "R: rubygem(activesupport)" is redundant. > - "R: ruby(abi) = 1.8" is mandatory Done > > * Documents > - "%{geminstdir}/test" should be marked as %doc > - Also "%{geminstdir}/Rakefile" can be marked as %doc (this is > like "Makefile" in autotools system). Done > > * %check > - rubygem(jeweler) is not strictly needed for "$ rake test", > so please enable "$ rake test". Done > > ! Some notes: > - Without rubygem(ruby-debug) being installed, "$ rake test" > aborts like > ---------------------------------------------------------------- > $ rake test --trace > <snip> > ---------------------------------------------------------------- > However, in fact "ruby-debug" does not seem to be needed. > > - After commenting out 'require "ruby-debug"' from ./test/test_helper.rb, > some tests fails like Done, patch0 added to do this. > ---------------------------------------------------------------- > $ rake test --trace > <snip> > --------------------------------------------------------------- > Maybe it is better that you package bcrypt-ruby? > http://bcrypt-ruby.rubyforge.org/ Package review request submitted http://bugzilla.redhat.com/show_bug.cgi?id=622946 rubygem(bcrypt-ruby) is added as a BR(check) dependency. Once added, rake test successfully completes. Updated SRPM / Spec here: pec URL: http://mo.morsi.org/files/gems/rubygem-authlogic.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-authlogic-2.1.6-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review