Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=621015 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-08-05 13:52:28 EDT --- Some notes: * Unused macro - %ruby_sitelib seems to be used nowhere. * Latest version - Latest version seems 2.1.6. * Requires - ">= 0" part on "R: rubygem(activesupport)" is redundant. - "R: ruby(abi) = 1.8" is mandatory * Documents - "%{geminstdir}/test" should be marked as %doc - Also "%{geminstdir}/Rakefile" can be marked as %doc (this is like "Makefile" in autotools system). * %check - rubygem(jeweler) is not strictly needed for "$ rake test", so please enable "$ rake test". ! Some notes: - Without rubygem(ruby-debug) being installed, "$ rake test" aborts like ---------------------------------------------------------------- $ rake test --trace (in /home/tasaka1/rpmbuild/INSTROOT/rubygem-authlogic-2.1.5-1.fc-foo-tasaka1/usr/lib/ruby/gems/1.8/gems/authlogic-2.1.5) Jeweler (or a dependency) not available. Install it with: sudo gem install jeweler ** Invoke test (first_time) ** Execute test .... .... /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require': no such file to load -- ruby-debug (LoadError) from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require' from ./test/test_helper.rb:3 from ./test/i18n_test.rb:1:in `require' from ./test/i18n_test.rb:1 from /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:4:in `load' from /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:4 from /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:4:in `each' from /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:4 rake aborted! ---------------------------------------------------------------- However, in fact "ruby-debug" does not seem to be needed. - After commenting out 'require "ruby-debug"' from ./test/test_helper.rb, some tests fails like ---------------------------------------------------------------- $ rake test --trace (in /home/tasaka1/rpmbuild/INSTROOT/rubygem-authlogic-2.1.5-1.fc-foo-tasaka1/usr/lib/ruby/gems/1.8/gems/authlogic-2.1.5) Jeweler (or a dependency) not available. Install it with: sudo gem install jeweler ** Invoke test (first_time) ** Execute test .... .... 1) Error: test_transitioning_password(ActsAsAuthenticTest::PasswordTest): NameError: uninitialized constant BCrypt /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:443:in `load_missing_constant' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:80:in `const_missing' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/dependencies.rb:92:in `const_missing' ./test/../lib/authlogic/crypto_providers/bcrypt.rb:83:in `new_from_hash' ./test/../lib/authlogic/crypto_providers/bcrypt.rb:60:in `matches?' ./test/../lib/authlogic/acts_as_authentic/password.rb:259:in `valid_password?' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/callbacks.rb:207:in `each_with_index' ./test/../lib/authlogic/acts_as_authentic/password.rb:253:in `each' ./test/../lib/authlogic/acts_as_authentic/password.rb:253:in `each_with_index' ./test/../lib/authlogic/acts_as_authentic/password.rb:253:in `valid_password?' ./test/acts_as_authentic_test/password_test.rb:224:in `transition_password_to' ./test/acts_as_authentic_test/password_test.rb:221:in `each' ./test/acts_as_authentic_test/password_test.rb:221:in `transition_password_to' ./test/acts_as_authentic_test/password_test.rb:163:in `test_transitioning_password' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/testing/setup_and_teardown.rb:62:in `__send__' /usr/lib/ruby/gems/1.8/gems/activesupport-2.3.5/lib/active_support/testing/setup_and_teardown.rb:62:in `run' --------------------------------------------------------------- Maybe it is better that you package bcrypt-ruby? http://bcrypt-ruby.rubyforge.org/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review