Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226457 --- Comment #8 from Phil Knirsch <pknirsch@xxxxxxxxxx> 2010-08-06 11:49:03 EDT --- (In reply to comment #7) > Review: > + Built successfully in koji for F14 > => http://koji.fedoraproject.org/koji/taskinfo?taskID=2384447 > + No tags found for 1.5.4 in upstream so unable to verify source but I think > that is ok. > > Oh! wait looks some problem with SPEC file. Seems what you said above as fixed > is not matching to spec in given srpm. > here are those issues > 1) please remove line for pyc files removal in preun in comment#2 > I can see that > rpm -qf /usr/share/system-config-httpd/*.pyc > ==> system-config-httpd-1.5.2-1.fc13.noarch > Ah yes, just saw those as well and thats automatically handled by RPM these days. Fixed in latest version. > 2)I think I still see %{_datadir}/kontrol-panel in spec. > Odd, i could have sworn i fixed that but it wasn't. Fixed now though. > 3) I think BR: and R: for this package should be > BuildRequires: python2-devel, libglade2-devel, gettext, intltool > Requires: pygtk2-libglade, gnome-python2-canvas, gnome-python2-gnome, httpd, > usermode, python-lxml > Looks good, have exactly those in the spec file now. > > Can we have updated package here for final review? Done: http://pknirsch.fedorapeople.org/src/system-config-httpd-1.5.5-1.el6.src.rpm Thanks & regards, Phil -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review