[Bug 226457] Merge Review: system-config-httpd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226457

--- Comment #7 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-08-06 05:45:51 EDT ---
Review:
+ Built successfully in koji for F14
=> http://koji.fedoraproject.org/koji/taskinfo?taskID=2384447
+ No tags found for 1.5.4 in upstream so unable to verify source but I think
that is ok.

Oh! wait looks some problem with SPEC file. Seems what you said above as fixed
is not matching to spec in given srpm.
here are those issues
1) please remove line for pyc files removal in preun in comment#2
I can see that
rpm -qf /usr/share/system-config-httpd/*.pyc
==> system-config-httpd-1.5.2-1.fc13.noarch

2)I think I still see %{_datadir}/kontrol-panel in spec. 

3) I think BR: and R: for this package should be
BuildRequires: python2-devel, libglade2-devel, gettext, intltool
Requires: pygtk2-libglade, gnome-python2-canvas, gnome-python2-gnome, httpd,
usermode, python-lxml


Can we have updated package here for final review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]