Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=617592 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-07-29 12:56:22 EDT --- Hi Chen Lei, here are some quick comments: - since the name of the upstream project and the tarball is 'accounts-qt', the package should get this name too - concerning the patch, I suggest to replace value = qlonglong(g_value_get_int64(&val)); with value = qint64(g_value_get_int64(&val)); and value = qlonglong(g_value_get_uint64(&val)); with value = quint64(g_value_get_uint64(&val)); - add switch -f to all rm statements to ensure the files/dirs are actually removed - the directory %{_libdir}/qt4/mkspecs/ is owned by qt-devel, so you should add Requires: qt-devel to the devel package - in %description devel, replace "for the accounts-qt" with "for %{name}" - the doxygen docs should go to %{_defaultdocdir}/%{name}-%{version}/ - please be more specific in %files devel, e.g.: %{_libdir}/lib*.so %{_includedir}/accounts-qt/ %{_libdir}/pkgconfig/accounts-qt.pc %{_libdir}/qt4/mkspecs/* ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review