Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=547601 Jérôme Fenal <jfenal@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jfenal@xxxxxxx --- Comment #7 from Jérôme Fenal <jfenal@xxxxxxx> 2010-07-24 18:28:17 EDT --- This is not a review, because I'm not yet a blessed Fedora Packager, but a few useful (I hope) comments : Name of the package is perl-pfacter, perl package is pfacter, but perl namespace of this module is Pfacter. I'd need to check the right case for the right case naming, but I guess you're right here. In %install : - s/PERL_INSTALL_ROOT/DESTDIR/ - chmod -R u+w could be replaced by %{_fixperms} In %files : - No README, no Changes despite being present in the source tarball. - %{perl_vendorlib}/* is way too open. Using %dir %{perl_vendorlib}/Pfacter and %{perl_vendorlib}/Pfacter.pm would be ok. - What's the difference between /usr/share/perl5/pfacter.pod & /usr/share/man/man3/pfacter.3pm.gz in the resulting package ? The first one does not add anything. HTH, J. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review