Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542990 --- Comment #24 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2010-07-24 17:57:36 EDT --- (In reply to comment #23) > Summary: > 1) Correct histograming spelling. Histogramming is spelt correctly (with two m's - just like programming). This is a proper English word - it is present participle form of the verbified noun. Verbification of nouns is common practice in the English language, and the fact that the spellcheck dictionary doesn't know about this particular case doesn't make it incorrect. Google gives 34,000 hits for the word. > 2) Try and remove the provides of libPyROOT.so.5.26()(64bit) As explained above (comment #5) libPyROOT is a bidirectional interface, that works both from Python to root and from root to Pyhton. There is a potential legitimate use case for someone wanting to use the root to Python interface in an application that uses the root libraries to link to this library. If such an application was put in an rpm it would require this provides. It is therefore not proper to filter it out. > 3) I'm sure it says on the fedora pages some where to use > sed rather than dos2unix but can't find it now. This used to be true, but the guidelines have changed. They now read: http://fedoraproject.org/wiki/Packaging/Guidelines#Rpmlint_Errors "This error occurs because of DOS line breaks in a file. Fix it in the %prep section with sed or dos2unix." > 4) Explanation for the excludearch of ppc. It is exclude arch ppc64 - 32 bit ppc works. The ppc64 build segfaults during an invocation of cint. I didn't find any good documentation for this so I filed a bug report (referenced in the new spec file). The reply from upstream was that it is a known issue and they have no intent to fix it. > 5) Explanation for %{ix86} x86_64 and -cint package. It is cintex that is intel only. The cint package is OK. This is documented in the configure file. ./configure will turn off cintex if you try to enable it on something else than ix86 and x86_64, giving a warning about "incompatible Cintex architecture". So even if you tried to enable it configure wouldn't let you. I have added a comment to the spec file that references a relevant comment in an existing bug report. New version: http://www.grid.tsl.uu.se/review/root-5.26.00c-2.fc12.src.rpm http://www.grid.tsl.uu.se/review/root.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review