Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608069 --- Comment #7 from Chen Lei <supercyper1@xxxxxxxxx> 2010-07-23 13:17:38 EDT --- Some initial comments: 1. %global alphatag 20101207 ->%global alphatag 20100712 See https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages 2. ExcludeArch: sparc ->ExcludeArch: %sparc rpm --eval %sparc sparc sparcv8 sparcv9 sparcv9v sparc64 sparc64v 3. Group: Development/Languages I think Gourp should be Development/Libraries, Development/Languages is compliler or runtime only(e.g. gcc perl jdk gfortran). 4. %files %defattr(-,root,root,-) %doc README.txt LICENSE.txt %{_libdir}/%{name}/libtango.a Those files should be removed to -devel subpackage,main package is meaningless. Also, you also add Provides: %{name}-static to -devel subpackage. See https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 5. %files documentation %defattr(-,root,root,-) %doc doc/example %files examples %defattr(-,root,root,-) %doc doc/html/ -documention should be renamed to -doc subpackage, if it's not big enough, it can also be merged to -devel subpackage. If -examples subpackage is not big enough, you can merge it to -devel or -doc subpackage. cp -rp doc/html/* %{buildroot}%{_defaultdocdir}/%{name}-%{version}/doc cp -rp doc/example/* %{buildroot}%{_defaultdocdir}/%{name}-%{version}/examples/ See https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation https://fedoraproject.org/wiki/Packaging_tricks#Examples -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review