Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594416 --- Comment #7 from Lubomir Rintel <lkundrak@xxxxx> 2010-07-23 13:03:50 EDT --- Thanks (In reply to comment #5) > The only problem is missing documentation (e.g. License file). Please > contact upstream and see if they would mind including it in CVS repos. Sent mail upstreamwards. > NEEDSWORK: All build dependencies must be listed in BuildRequires, except for > any that are listed in the exceptions section of the Packaging Guidelines ; > inclusion of those as BuildRequires is optional. Apply common sense. > > As you mentioned this package needs new groovy/antlr3-tool > packages. It would be better to actually state minimal required > versions (e.g. BR: antlr3-tool >= 3.2-7 I believe) Done. > NEEDSWORK: Packages must NOT bundle copies of system libraries. > > There are jar files in src/lib. They do not appear to be used (package > compiled fine without them) so it should not be a problem to remove them. Done. >... and > perhaps even make comment about using maven a little more > descriptive. Done. SPEC: http://v3.sk/~lkundrak/SPECS/json-lib.spec SRPM: http://v3.sk/~lkundrak/SRPMS/json-lib-2.3-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review