Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226813 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #17 from Kevin Fenzi <kevin@xxxxxxxxx> 2010-07-18 20:07:06 EDT --- Wow... here we are 3 years later. :) I went ahead and re-ran my review checklist against the current version: OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 74c5b275544400082a1cde806c98682a zsh-4.3.10.tar.bz2 74c5b275544400082a1cde806c98682a zsh-4.3.10.tar.bz2.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin OK - check for outstanding bugs on package (merge reviews/rename/re-reviews). Issues: 1. Non blocker, but would '--enable-cap' and '--enable-multibyte' be worth enabling? 2. the tests do indeed hang in local mock here. How does this work in koji? 3. Non blocker, I tried to nuke the %makeinstall with no luck. Perhaps just add a note that it's required? 4. rpmlint says: Can't this just be removed now: zsh.src:26: E: prereq-use fileutils grep /sbin/install-info zsh.src: E: specfile-error warning: line 26: prereq is deprecated: Prereq: fileutils grep /sbin/install-info Misc ignorable issues, fix if you like: zsh.src:136: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 136) zsh.x86_64: E: non-executable-script /usr/share/zsh/4.3.10/functions/sticky-note 0644L /bin/zsh zsh.x86_64: E: script-without-shebang /usr/share/zsh/4.3.10/functions/mere zsh.x86_64: E: non-executable-script /usr/share/zsh/4.3.10/functions/calendar_add 0644L /bin/zsh zsh.x86_64: W: file-not-utf8 /usr/share/doc/zsh-4.3.10/LICENCE zsh.x86_64: W: dangerous-command-in-%postun cp zsh.x86_64: E: use-tmp-in-%postun I don't see any blockers here, just suggestions, so this package is APPROVED. Please do consider the above suggestions for the package moving forward. ;) You can close this at your leasure... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review