Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=613525 --- Comment #5 from Randall Berry <randyn3lrx@xxxxxxxxx> 2010-07-17 17:51:58 EDT --- Spec: http://dp67.fedorapeople.org/pkgs/SPECS/klog.spec SRPM: http://dp67.fedorapeople.org/pkgs/SRPMS/klog-0.5.6-4.fc13.src.rpm (In reply to comment #4) > +# klog.sh.in - Install wraapper script for klog > I bet "wraapper" is not in the dictionary, even in HAM operators' one :) Done: Fixed my twitchy finger action. :) > In the following sequence > mkdir -p $RPM_BUILD_ROOT/%{_sysconfdir}/skel/.%{name}/ > mkdir -p $RPM_BUILD_ROOT/%{_sysconfdir}/skel/.%{name}/data/ > mkdir -p $RPM_BUILD_ROOT/%{_sysconfdir}/skel/.%{name}/awa/ > there is no actual error, but > a) the first command is not needed, given that the second and third ones would > create the whole directory structure, due to the "-p" parameter. > b) OTOH, if you preserve the first command in the sequence, the second and > third one no longer need "-p" because the whole directory structure would have > been created by the first command. Done: Removed first command. > The following part > desktop-file-validate \ > $RPM_BUILD_ROOT/%{_datadir}/applications/kde4/%{name}.desktop > is superflous, given that you have used desktop-file-install to install AND > verfy the file. Please either use desktop-file-install to verify the file and > put it in place OR desktop-file-validate if the installer already copies the > file to the correct place. Done: Used desktop-file-install instead of both install/validate > As a matter of style I think that you should have used either use %{name} or > "klog" in both desktop-file-* invocations. Done: Changed klog in desktop-file-install to %{name} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review