Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=613525 --- Comment #4 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> 2010-07-17 09:03:55 EDT --- +# klog.sh.in - Install wraapper script for klog I bet "wraapper" is not in the dictionary, even in HAM operators' one :) In the following sequence mkdir -p $RPM_BUILD_ROOT/%{_sysconfdir}/skel/.%{name}/ mkdir -p $RPM_BUILD_ROOT/%{_sysconfdir}/skel/.%{name}/data/ mkdir -p $RPM_BUILD_ROOT/%{_sysconfdir}/skel/.%{name}/awa/ there is no actual error, but a) the first command is not needed, given that the second and third ones would create the whole directory structure, due to the "-p" parameter. b) OTOH, if you preserve the first command in the sequence, the second and third one no longer need "-p" because the whole directory structure would have been created by the first command. The following part desktop-file-validate \ $RPM_BUILD_ROOT/%{_datadir}/applications/kde4/%{name}.desktop is superflous, given that you have used desktop-file-install to install AND verfy the file. Please either use desktop-file-install to verify the file and put it in place OR desktop-file-validate if the installer already copies the file to the correct place. As a matter of style I think that you should have used either use %{name} or "klog" in both desktop-file-* invocations. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review