Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478613 --- Comment #19 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-07-16 07:06:56 EDT --- One last thing -- the Emacs packages should be emacs-ledger and emacs-ledger-el since they won't work on XEmacs -- unless you're supporting both GNU and XEmacs explicitly, -common- should not exist. See the packaging guideline -- XEmacs files are installed into a totally separate directory. Sorry for forgetting to mention this. We don't have a package popularity survey, but from looking at Debian's numbers it looks like GNU Emacs installations are outnumbering XEmacs by a ratio of 4:1, so given the two choices of supporting GNU Emacs only or supporting both, the former is probably easiest. (From experience, I package bigloo which supports both Emacs flavors, but in the latest versions XEmacs support does not even work out-of-the-box and I ended up disabling them until a fix is found) Apart from the subpackage naming, this package is ready for approval - make that change and I'll officially approve it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review