Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608420 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2010-07-14 23:51:49 EDT --- + source files match upstream. 48019aa641a27d5010f79d1d3f455b36 Test-Regression-0.05.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2321042 + package installs properly. - rpmlint has a meaningful complaint: perl-Test-Regression.noarch: I: checking perl-Test-Regression.noarch: I: checking-url http://search.cpan.org/dist/Test-Regression/ (timeout 10 seconds) perl-Test-Regression.src: I: checking perl-Test-Regression.src: I: checking-url http://search.cpan.org/dist/Test-Regression/ (timeout 10 seconds) perl-Test-Regression.src: I: checking-url http://www.cpan.org/modules/by-module/Test/Test-Regression-0.05.tar.gz (timeout 10 seconds) perl-Test-Regression.src: W: invalid-url Source0: http://www.cpan.org/modules/by-module/Test/Test-Regression-0.05.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + final provides and requires are sane: perl(Test::Regression) = 0.05 perl-Test-Regression = 0.05-1.fc14 = perl(base) perl(FileHandle) perl(:MODULE_COMPAT_5.12.1) perl(strict) perl(Test::Builder::Module) perl(Test::Differences) perl(warnings) + %check is present and all tests pass. + ./Build test # Testing Test::Regression 0.05, Perl 5.012001, /usr/bin/perl t/00-load.t ....... ok t/boilerplate.t ... ok t/changes.t ....... skipped: Author test. Set $ENV{TEST_AUTHOR} to a true value to run. t/manifest.t ...... skipped: Author test. Set $ENV{TEST_AUTHOR} to a true value to run. t/open.t .......... ok t/perlcritic.t .... skipped: Author test. Set $ENV{TEST_AUTHOR} to a true value to run. t/pod-coverage.t .. skipped: Test::Pod::Coverage 1.08 required for testing POD coverage t/pod.t ........... skipped: Test::Pod 1.22 required for testing POD t/podspell.t ...... skipped: Author test. Set $ENV{TEST_AUTHOR} to a true value to run. t/prereq.t ........ skipped: Author test. Set $ENV{TEST_PREREQ} to a true value to run. t/print.t ......... ok t/regression.t .... ok All tests successful. Files=12, Tests=10, 0 wallclock secs ( 0.04 usr 0.02 sys + 0.41 cusr 0.06 csys = 0.53 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. Source0 is not found. Replace with http://search.cpan.org/CPAN/authors/id/S/SI/SILASMONK/Test-Regression-0.05.tar.gz and you're good to go. The skipped author tests are okay, but you may want to BR perl(Test::Pod::Coverage) to enable the pod tests. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review