Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611033 --- Comment #2 from Jeff Garzik <jgarzik@xxxxxxxxxx> 2010-07-13 17:25:59 EDT --- (In reply to comment #1) > - First of all, cool package name! thanks :) > ! Some brief explanations on the additional sources would be nice. I'd be glad to, but am at a loss as to what people might be looking for? Just something like "init.d and sysconf files for <this-daemon>"? Or can you point to another Fedora package as a useful example? > ? Shouldn't the Group tag for the base package be "System > Environment/Libraries"? fixed > ? cld/server.c and cld/cldbadm.c have references to the directory > CLD_LIBDIR "/cld/lib" > where CLD_LIBDIR is set to %{_libdir} by the configure script. But this > directory is not packaged. Are we missing something? yes. fixed. > * BRs: libevent-devel zlib-devel procps > seem redundant. > > ? Why is this library linked to zlib? I don't see any usage. zlib seems superfluous. Removed. Not sure how the others are redundant? > However rpmlint on the installed hail package says: > hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 > g_thread_functions_for_glib_use > hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 > g_threads_got_initialized > hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 xmlFree > hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 g_free > hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 > SSL_connect > ... lots of them > > Indeed when I run "ldd -r" on the DSO, I see lots of undefined symbols. Is this > library linked improperly? The pkgconfig info file specifies additional linking libraries, which seems to fix this in downstream applications. But regardless, I wonder if this is non-standard behavior for a shared lib? Will investigate. > * The file chunkc.h contains > #include <openssl/ssl.h> > #include <glib.h> > Thus the devel subpackage nedds to require openssl-devel, glib2-devel fixed > * I think these > Requires(post): chkconfig > Requires(preun): chkconfig initscripts > need to go to the cld and chunkd subpackages. The main package contains the > library only. It doesn't have any init scripts. fixed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review