Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611033 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-07-08 01:45:36 EDT --- - First of all, cool package name! ! Some brief explanations on the additional sources would be nice. ? Shouldn't the Group tag for the base package be "System Environment/Libraries"? ? cld/server.c and cld/cldbadm.c have references to the directory CLD_LIBDIR "/cld/lib" where CLD_LIBDIR is set to %{_libdir} by the configure script. But this directory is not packaged. Are we missing something? * BRs: libevent-devel zlib-devel procps seem redundant. ? Why is this library linked to zlib? I don't see any usage. * rpmlint on the RPMs says: chunkd.x86_64: W: incoherent-subsys /etc/rc.d/init.d/chunkd $prog hail.src: W: name-repeated-in-summary C Hail cld.x86_64: W: no-documentation cld.x86_64: W: no-manual-page-for-binary cld cld.x86_64: W: no-manual-page-for-binary cldcli cld.x86_64: W: no-manual-page-for-binary cldbadm cld.x86_64: W: incoherent-subsys /etc/rc.d/init.d/cld $prog These can all be ignored. However rpmlint on the installed hail package says: hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 g_thread_functions_for_glib_use hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 g_threads_got_initialized hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 xmlFree hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 g_free hail.x86_64: W: undefined-non-weak-symbol /usr/lib64/libhail.so.0.100.1 SSL_connect ... lots of them Indeed when I run "ldd -r" on the DSO, I see lots of undefined symbols. Is this library linked improperly? * The file chunkc.h contains #include <openssl/ssl.h> #include <glib.h> Thus the devel subpackage nedds to require openssl-devel, glib2-devel * I think these Requires(post): chkconfig Requires(preun): chkconfig initscripts need to go to the cld and chunkd subpackages. The main package contains the library only. It doesn't have any init scripts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review