Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=613067 --- Comment #4 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-07-09 19:10:25 EDT --- package name: ok spec file name: ok packaging guidelines: small cleanups are possible if the package is only for F13+: - remove BuildRoot - remove initial rm -rf in %install - ditch %clean things that need fixing: - ExclusiveArch: should have a comment explaining why the package only works on some arches and ideally a bug ref. See https://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures - the CFLAGS munging needs justification in a comment. Why remove -Wall ? and in particular, why remove _FORTIFY_SOURCE ? See https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags - if libspice-server.a must be packaged, it needs to go into a -static subpackage. See https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries license: ok license field/license file: see previous comment spec file language: ok spec file readable: ok buildable: ok ExcludeArch: see above BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok. (pedants prefer the 4-argument form of %defattr) macro use: ok permissable content: ok large docs: ok %doc content: ok headers: ok shared libs: ok static libs: see above devel deps: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review