Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: <libtune> - <standard API to access the kernel tunables> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210007 ------- Additional Comments From Nadia.Derbey@xxxxxxxx 2006-11-09 09:10 EST ------- Konrad, sorry for the delay but I have been out of my office for almost 2 weeks! (In reply to comment #12) > 1). > Licenses. The spec files says GPL v2.1, the tests,scripts, and templates usE GPL > v2.0 and the lib uses LGPG. > Fixed the License: field in the spec file + many source files where the license text was completely wrong (it was a big mess and don't know where I got that text from :-( ). > 2). rpmlint: > > [konrad@dyn448114 i386]$ rpmlint -v libtune-devel-0.10-2.i386.rpm > I: libtune-devel checking > W: libtune-devel service-default-enabled /etc/rc.d/init.d/chtunedb > W: libtune-devel incoherent-init-script-name chtunedb > > I would consider the two above to be harmless and intentional. Right: W1: the service has to be enabled by default W2: I thought that calling that binary libtune or libtuned was not meaningful enough > > 3). It fails compilation on 64-bit (this FC5-x86_64) > Fixed New links are: Spec URL: http://libtune.sourceforge.net/specfiles/FE3/libtune.spec SRPM URL: http://prdownloads.sourceforge.net/libtune/libtune-0.10-3.src.rpm?download -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review