Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: <libtune> - <standard API to access the kernel tunables> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210007 ------- Additional Comments From konradr@xxxxxxxxxx 2006-11-01 09:54 EST ------- 1). Licenses. The spec files says GPL v2.1, the tests,scripts, and templates usE GPL v2.0 and the lib uses LGPG. There are no GPL v2.1, there is LGPG v2.1, which is what I think you meant for the spec file, but it states: " This library is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public # License as published by the Free Software Foundation; either # version 2.1 of the License, or (at your option) any later version. " The field: License has only LGPL, but this has GPL as well (in -devel) package. 2). rpmlint: [konrad@dyn448114 i386]$ rpmlint -v libtune-devel-0.10-2.i386.rpm I: libtune-devel checking W: libtune-devel service-default-enabled /etc/rc.d/init.d/chtunedb W: libtune-devel incoherent-init-script-name chtunedb I would consider the two above to be harmless and intentional. 3). It fails compilation on 64-bit (this FC5-x86_64) make: Leaving directory `/builddir/build/BUILD/libtune-0.10-2/templates' + db/libtuncleandb /var/tmp/libtune-0.10-2-root-brewbuilder//usr/share/libtune/tundb_kernel /var/tmp/libtune-0.10-2-root-brewbuilder//usr/share/libtune/tundb_distro + /usr/lib/rpm/find-debuginfo.sh /builddir/build/BUILD/libtune-0.10-2 0 blocks find: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib/debug: No such file or directory + /usr/lib/rpm/redhat/brp-compress + /usr/lib/rpm/redhat/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/redhat/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump + /usr/lib/rpm/brp-python-bytecompile Processing files: libtune-0.10-2 error: File not found: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib64/libtune.la error: File not found by glob: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib64/libtune.so.* Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.80952 + umask 022 + cd /builddir/build/BUILD + cd libtune-0.10-2 + DOCDIR=/var/tmp/libtune-0.10-2-root-brewbuilder/usr/share/doc/libtune-0.10 + export DOCDIR + rm -rf /var/tmp/libtune-0.10-2-root-brewbuilder/usr/share/doc/libtune-0.10 + /bin/mkdir -p /var/tmp/libtune-0.10-2-root-brewbuilder/usr/share/doc/libtune-0.10 + cp -pr COPYING lib/LGPL ChangeLog /var/tmp/libtune-0.10-2-root-brewbuilder/usr/share/doc/libtune-0.10 + exit 0 Processing files: libtune-devel-0.10-2 error: File not found: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib64/libtune.a error: File not found: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib64/libtune.so Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.80952 + umask 022 + cd /builddir/build/BUILD + cd libtune-0.10-2 + DOCDIR=/var/tmp/libtune-0.10-2-root-brewbuilder/usr/share/doc/libtune-devel-0.10 + export DOCDIR + rm -rf /var/tmp/libtune-0.10-2-root-brewbuilder/usr/share/doc/libtune-devel-0.10 + /bin/mkdir -p /var/tmp/libtune-0.10-2-root-brewbuilder/usr/share/doc/libtune-devel-0.10 + cp -pr templates/GPL /var/tmp/libtune-0.10-2-root-brewbuilder/usr/share/doc/libtune-devel-0.10 + exit 0 Processing files: tunables-data-2.6.16-0.10-2 Provides: tunables-generic-data = 0.10 Requires(interp): /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Requires(post): /bin/sh Requires(preun): /bin/sh Requires: /bin/sh Processing files: tunables-data-2.6.18-0.10-2 Provides: tunables-generic-data = 0.10 Requires(interp): /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Requires(post): /bin/sh Requires(preun): /bin/sh Requires: /bin/sh Processing files: tunables-data-FC5-2.6.16-0.10-2 Provides: tunables-distro-data = 0.10 Requires(interp): /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Requires(post): /bin/sh Requires(preun): /bin/sh Requires: tunables-data-2.6.16 = 0.10 Processing files: tunables-data-FC6-2.6.18-0.10-2 Provides: tunables-distro-data = 0.10 Requires(interp): /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 Requires(post): /bin/sh Requires(preun): /bin/sh Requires: tunables-data-2.6.18 = 0.10 Processing files: libtune-debuginfo-0.10-2 RPM build errors: File not found: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib64/libtune.la File not found by glob: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib64/libtune.so.* File not found: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib64/libtune.a File not found: /var/tmp/libtune-0.10-2-root-brewbuilder/usr/lib64/libtune.so -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review