Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611648 --- Comment #4 from Peter Hutterer <peter.hutterer@xxxxxxxxxx> 2010-07-06 20:29:08 EDT --- (In reply to comment #1) > Review: > - Why do you BR git? Because you use it to make the sources? sorry, you're right, that's not needed. > - name: How about "libmtdev" like e.g. libacpi or libmpd? I was tempted, but as you said - upstream naming is mtdev so I decided to stick with it. > - %doc: Please add README and CREDITS > - Please use: 'make install DESTDIR=%{buildroot} INSTALL="install -p"' > - You mix $RPM_BUILD_ROOT and %{buildroot} all three fixed. > - libfoo.so needs to be in the -devel package: > from rpmlint: mtdev.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/libmtdev.so moved > - mtdev.x86_64: E: library-without-ldconfig-postin /usr/lib64/libmtdev.so.1.0.0 > mtdev.x86_64: E: library-without-ldconfig-postun /usr/lib64/libmtdev.so.1.0.0 > see: https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > > - mtdev-devel.x86_64: W: summary-not-capitalized C multitouch protocol > translation library development package. your rpmlint is more picky than mine it seems :) I didn't get any of these, I wonder what I'm doing wrong here. I also bumped the release down to 1, damn copy/paste... Updated files are available on: http://people.freedesktop.org/~whot/mtdev-1.0.1-1.20100706.fc14.src.rpm http://people.freedesktop.org/~whot/mtdev.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review