[Bug 608326] Review Request: gtkmm30 - C++ interface for the GTK+ library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608326

--- Comment #4 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-07-05 18:52:28 EDT ---
Alright, here is the rest of the complete review:

* rpmlint says:
    gtkmm30.src: W: invalid-url Source0:
http://ftp.gnome.org/pub/GNOME/sources/gtkmm/2.90.4.0./gtkmm-2.90.4.0.tar.bz2
HTTP Error 404: Not Found 
    gtkmm30.x86_64: W: spelling-error %description -l en_US gtkmm 
These two can be ignored. However

    gtkmm30.x86_64: W: spelling-error %description -l en_US typesafe -> type
safe, type-safe, typeset
    gtkmm30.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libgtkmm-3.0.so.1.1.0 ['/usr/lib64']
These two need a fix

! Please make the description span 80 columns as much as possible. Currently it
is set to 70 columns.

! BRs: cairomm-devel and glibmm24-devel seem redundant. They get pulled it by
other dependencies. They don't cause any harm though.

! The package gtk-doc is listed as a dependency for directory ownership. This
is fine for now. However keep in mind that there is a discussion to change this
policy so that all packages that use usr/share/gtk-doc/ must own this
directory. See:

 
https://fedoraproject.org/wiki/PackagingDrafts/Revised_File_and_Directory_Ownership#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]