Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608326 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #3 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-07-05 17:57:36 EDT --- Hi, this is my preliminary notes. I still have a few other things to check to complete the review: ! The file ChangeLog can go to devel package, as we have the user-friendly NEWS file in the main package. ? Is it possible to run the tests in the tests/ directory in a %check section? Or should we include them in the devel package? * Package name is odd. Actually the whole gtk related packages have weird names. I see that they didn't pass the merge review yet, that's probably why. Since there is no package called gtkmm, can we call this package simply gtkmm, so that we can stay more consistent with the guidelines? * There is a problem with license. We have a file called COPYING.tools (GPLv2), which suggests that the tools/ directory is GPLv2. Indeed when we look at tools/extra_defs_gen/generate_defs_gtk.cc we see that it is licensed GPLv2+. However this file does not get installed. On the other hand, the contents of the directory tools/m4 get installed. Unfortunately, these files do not indicate a license. Are these files GPL or LGPL? This needs to be clarified by upstream. * Macro issue: We should use %{_datadir} instead of /usr/share - Requires: pkgconfig is missing in the devel package. However this is not a problem if the package will be Fedora only. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review