Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593804 --- Comment #4 from Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> 2010-06-29 16:41:34 EDT --- Hi Magnus, thanks for the review! License comes from the source: /* * Copyright (C) 2010 Alexey Noskov <alexey.noskov@xxxxxxxxx> * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of * the License or (at your option) version 3 or any later version Makes it up to v3+ I made better use of macros but not for the *.so. It's annoying if upstream decides to change something in the name of the .so and it fails build. With the wildcard i'm able to catch them all. http://thomasj.fedorapeople.org/reviews/plasma-runner-events.spec http://thomasj.fedorapeople.org/reviews/plasma-runner-events-0.3.0-3.fc13.src.rpm rpmlint plasma-runner-events.spec ../SRPMS/plasma-runner-events-0.3.0-3.fc13.src.rpm ../RPMS/x86_64/plasma-runner-events-*-0.3.0-3* plasma-runner-events.src: W: spelling-error Summary(en_US) todos -> dodos, to dos, to-dos plasma-runner-events.src: W: spelling-error %description -l en_US todos -> dodos, to dos, to-dos plasma-runner-events.src: W: spelling-error %description -l en_US todo -> tod, too, dodo 2 packages and 1 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review