Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-twisted-core - An asynchronous networking framework written in Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208169 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-11-07 10:11 EST ------- Review: - package and spec naming OK - package meets guidelines - license is MIT, matches spec, text included - spec file written in English and is legible - sources match upstream - package builds ok in mock for rawhide, fc5, and fc6 (i386 and x86_64) - BR's OK - no locales or libraries to worry about - not relocatable - no directory ownership or permissions problems - %clean section present and correct - macro usage is consistent enough - code, not content - large doc directory properly split off into -doc subpackage - docs don't affect runtime - no pkgconfig files or libtool archives to worry about - not a GUI app, no desktop file needed - package appears to work OK - scriptlet is sane - subpackages have proper dependencies Nits: rpmlint output: W: python-twisted-core strange-permission twisted-dropin-cache 0775 W: python-twisted-core mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 39) Both trivially fixed; there's no need to have twisted-dropin-cache executable in the SRPM as it's installed with the correct mode anyway. Also see Comment #7. Once these are addressed, I'll be happy to approve. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review